Skip to content

fix: shared memory for evals #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: shared memory for evals #235

wants to merge 1 commit into from
+67 −46

Conversation

@cristipufu
Copy link
Member

@cristipufu cristipufu commented Oct 23, 2025 •
edited by github-actions bot
Loading

Development Package

  • Add this package as a dependency in your pyproject.toml:
[project]
dependencies = [
  # Exact version:
  "uipath-langchain==0.0.142.dev1002350828",

  # Any version from PR
  "uipath-langchain>=0.0.142.dev1002350000,<0.0.142.dev1002360000"
]

[[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
publish-url = "https://test.pypi.org/legacy/"
explicit = true

[tool.uv.sources]
uipath-langchain = { index = "testpypi" }

@cristipufu cristipufu self-assigned this Oct 23, 2025
@cristipufu cristipufu mentioned this pull request Oct 23, 2025
Closed
@cristipufu cristipufu requested a review from Copilot October 23, 2025 13:40
Copilot AI reviewed Oct 23, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes shared memory handling for evaluations by centralizing the memory management and ensuring consistent state persistence across evaluation runs. The changes address issues with execution ID management and shared memory configuration.

Key changes:

  • Introduces centralized connection string generation for SQLite state persistence
  • Restructures evaluation middleware to properly initialize and share AsyncSqliteSaver memory across runtime contexts
  • Removes hardcoded execution_id assignments in favor of default values

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/uipath_langchain/_cli/cli_run.py Removes execution_id assignment and uses hardcoded "default" value for debug bridge
src/uipath_langchain/_cli/cli_eval.py Adds shared memory initialization with AsyncSqliteSaver and restructures async flow
src/uipath_langchain/_cli/cli_debug.py Removes execution_id assignment for consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

src/uipath_langchain/_cli/cli_eval.py
_instrument_traceable_attributes()

event_bus = EventBus()

Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Empty line 48 creates unnecessary whitespace before the function definition. Remove this blank line for cleaner code formatting.

Suggested change

Copilot uses AI. Check for mistakes.
andrei-rusu
andrei-rusu approved these changes Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@andrei-rusu andrei-rusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't encountered the issue with this version

@cristipufu
Copy link
Member Author

Replaced by this PR #250

@cristipufu cristipufu closed this Nov 3, 2025
@cristipufu cristipufu deleted the fix/evals_shared_memory branch November 3, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@andrei-rusu andrei-rusu andrei-rusu approved these changes

@DragosBobolea DragosBobolea Awaiting requested review from DragosBobolea

@akshaylive akshaylive Awaiting requested review from akshaylive

@mjnovice mjnovice Awaiting requested review from mjnovice

@radu-mocanu radu-mocanu Awaiting requested review from radu-mocanu

@bai-uipath bai-uipath Awaiting requested review from bai-uipath

Assignees

@cristipufu cristipufu

Labels

build:dev

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cristipufu @andrei-rusu